{{ message }}
Handle nullability more accurately - #2933
Merged
Vincent Biret (baywet) merged 15 commits intoJul 13, 2026
Merged
Conversation
Youssef Fahmy (Youssef1313)
force-pushed
the
dev/ygerges/nullable
branch
from
July 9, 2026 10:38
67ef969 to
937b8eb
Compare
Youssef Fahmy (Youssef1313)
force-pushed
the
dev/ygerges/nullable
branch
from
July 9, 2026 10:39
937b8eb to
a70df43
Compare
Closed
4 tasks
Vincent Biret (baywet)
requested changes
Jul 9, 2026
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Getting closer (I'm only focusing my review on schema object field, and deserialization so far)
Member
This was referenced Sep 3, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

My previous PR was trying to handle nullability for enums specifically. This PR is more generalized to handle nulls more correctly as it was still buggy for non-enums.
In addition, the previous fix for enums didn't also fix all enum scenarios. It only fixed it when we are given "oneOf (null, schemaWithEnum)". But if we are given a schema reference instead, we are not going to add "null" to the reference and we will produce the wrong thing.
I'll leave comments on some specific updated tests to explain.