{{ message }}
Add type: "null" downcasting when in oneOf and anyOf for OpenAPI v3 - #2645
Merged
Vincent Biret (baywet) merged 13 commits intoDec 17, 2025
Merged
Conversation
Sjoerd van der Meer (desjoerd)
requested a review
from a team
as a code owner
December 12, 2025 21:45
Contributor
Author
Contributor
Author
|
Vincent Biret (@baywet) I've drafted this PR. Let me know what you think. Some parts are a little bit rough imho, for example the update to Edit: I just went ahead and implemented it. I know that I take a risk that this won't be merged or requires significant changes, then I will just see it as an exercise 🙃 |
Vincent Biret (baywet)
requested changes
Dec 15, 2025
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
…and use JsonNode.DeepEquals in tests Co-authored-by: desjoerd <2460430+desjoerd@users.noreply.github.com>
19 tasks
Co-authored-by: desjoerd <2460430+desjoerd@users.noreply.github.com>
Co-authored-by: desjoerd <2460430+desjoerd@users.noreply.github.com>
Address PR microsoft#2645 review comments: improve type checking logic and use JsonNode.DeepEquals
Contributor
Author
|
Vincent Biret (@baywet) I've addressed your comments (with copilot so I could go to the movie Zootopia 2 in the meantime 😎, AI let's programming really happen from your phone 😜). Let me know if I need to change something. |
Contributor
Author
Vincent Biret (baywet)
approved these changes
Dec 17, 2025
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add
type: "null"downcasting when in oneOf and anyOf for OpenAPI v3Description
This PR adds downcasting of oneOf and anyOf for openapi v3.
When writing OpenAPI v3 it will remove schemas from oneOf and anyOf with
{ "type": "null" }and apply it to the parent asnullable: true. It also tries to find a common overlappingtypewhich will also be applied to the parent schema asnullable: trueis only doing something whentypeis specified.It's between a bug-fix and a feature as the current situation downcasts
{ "type": "null" }to{ "nullable": true }which according to some clarifications of the spec doesn't do anything and tools expect thenullable: trueon the parent schema.Type of Change
Related Issue(s)
Changes Made
type: nullfor OpenAPI v3.Testing
Checklist
Versions applicability