Bump react-film@3.1.1-main.df870ea by compulim · Pull Request #4648 · microsoft/BotFramework-WebChat · GitHub
Skip to content

Bump react-film@3.1.1-main.df870ea #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compulim merged 3 commits into from
Feb 22, 2023
Merged

Bump react-film@3.1.1-main.df870ea #4648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
926878a
Bump react-film@3.1.1-main.df870ea
compulim Feb 21, 2023
b43e14e
Update entry
compulim Feb 21, 2023
0f398b3
Fix tests
compulim Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
10 changes: 2 additions & 8 deletions __tests__/html/suggestedActions.scroll.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@
await pageConditions.numActivitiesShown(2);

// WHEN: The right flipper button is clicked.
document.querySelector('[aria-label="Suggested actions"] [aria-label="right"]').click();

// TODO: This will be updated from "left/right" to "next/previous" when the carousel support customizing the aria-label. Commented out for now.
// document.querySelector('[aria-label="Suggested actions"] [aria-label="next"]').click();
document.querySelector('[aria-label="Suggested actions"] [aria-label="Next"]').click();

// THEN: It should scroll to the right.
await pageConditions.became(
Expand All @@ -38,10 +35,7 @@
);

// WHEN: The left flipper button is clicked.
document.querySelector('[aria-label="Suggested actions"] [aria-label="left"]').click();

// TODO: This will be updated from "left/right" to "next/previous" when the carousel support customizing the aria-label. Commented out for now.
// document.querySelector('[aria-label="Suggested actions"] [aria-label="previous"]').click();
document.querySelector('[aria-label="Suggested actions"] [aria-label="Previous"]').click();

// THEN: It should scroll back to the origin.
await pageConditions.became(
Expand Down
10 changes: 2 additions & 8 deletions __tests__/html/suggestedActions.scroll.rtl.html
View file
Open in desktop
Loading