iframe-proxy

Pujitha Paladugu (pujitha24) · 2026-09-05T09:49:18Z

Motivation:
utils/convert-hf-to-gguf-bitnet.py and utils/convert-bitnet-embedding-to-gguf.py
both wrote general.file_type = 40 for I2_S-quantized output. Per llama.cpp's
llama_ftype enum, 40 is LLAMA_FTYPE_MOSTLY_Q1_0 and 41 is
LLAMA_FTYPE_MOSTLY_I2_S, so tools that read this metadata field (e.g.
llama-cli) report the quant type as Q1_0 instead of I2_S. This does not affect
the tensor data itself or the model's numerical behavior -- only the
general.file_type metadata field and anything that displays/labels the quant
type from it.

Approach:
Change the hardcoded literal from 40 to 41 in both converters, and drop a
stale comment ("matches official model") on the now-corrected line that
implied 40 was intentional.

Two sibling converters (utils/convert.py, utils/convert-ms-to-gguf-bitnet.py)
write general.file_type for their own "i2" outtype from a different,
pre-existing GGMLFileType.MostlyI2 enum (value 2, not 40/41). That is a
separate, out-of-scope potential mislabeling in a different code path and is
not touched here.

Validation:
The 3rdparty/llama.cpp git submodule could not be checked out in this
environment (git submodule update --init failed with "No space left on
device"), and the torch/gguf/sentencepiece Python packages this repo's
converters import are not installed here either, so the full HF-to-GGUF
pipeline could not be run end to end.

To still validate by execution rather than inspection alone:

For convert-hf-to-gguf-bitnet.py: stubbed sys.modules for torch,
sentencepiece, safetensors, and gguf (the gguf stub's MODEL_ARCH /
GGMLQuantizationType return the attribute name for any access, and its
GGUFWriter just records add_file_type's argument), loaded the real,
unmodified utils/convert-hf-to-gguf-bitnet.py via
importlib.util.spec_from_file_location, built a BitnetModel via
object.new with ftype set to the I2_S sentinel, and called the real
Model.set_gguf_parameters() method on it. Before the fix this recorded
file_type 40; after changing 40 to 41 in the source, rerunning the same
harness recorded file_type 41.
For convert-bitnet-embedding-to-gguf.py: read the exact ftype-selection
if/elif/else block out of the file at runtime and exec'd that extracted
source text (unmodified from disk) with args.outtype = "i2_s"; the
resulting ftype was 40 before the fix and 41 after.
python3 -m py_compile on both changed files passes.
Verified independently via the GitHub API that this repo's pinned
llama.cpp submodule commit (390c307752ab78fd8189f359d6954c9ba1be74af)
defines LLAMA_FTYPE_MOSTLY_Q1_0 = 40 and LLAMA_FTYPE_MOSTLY_I2_S = 41 in
include/llama.h, confirming 41 is the correct value.

Not run: the actual HF checkpoint -> GGUF conversion end to end, and
llama-quantize/llama-cli against a real model (blocked by the submodule
checkout failure above).

Report: #619
Signed-off-by: Pujitha Paladugu 10557236+pujitha24@users.noreply.github.com
Assisted-by: claude-sonnet-5 (via Claude Code)

Fixes #619

Motivation: utils/convert-hf-to-gguf-bitnet.py and utils/convert-bitnet-embedding-to-gguf.py both wrote general.file_type = 40 for I2_S-quantized output. Per llama.cpp's llama_ftype enum, 40 is LLAMA_FTYPE_MOSTLY_Q1_0 and 41 is LLAMA_FTYPE_MOSTLY_I2_S, so tools that read this metadata field (e.g. llama-cli) report the quant type as Q1_0 instead of I2_S. This does not affect the tensor data itself or the model's numerical behavior -- only the general.file_type metadata field and anything that displays/labels the quant type from it. Approach: Change the hardcoded literal from 40 to 41 in both converters, and drop a stale comment ("matches official model") on the now-corrected line that implied 40 was intentional. Two sibling converters (utils/convert.py, utils/convert-ms-to-gguf-bitnet.py) write general.file_type for their own "i2" outtype from a different, pre-existing GGMLFileType.MostlyI2 enum (value 2, not 40/41). That is a separate, out-of-scope potential mislabeling in a different code path and is not touched here. Validation: The 3rdparty/llama.cpp git submodule could not be checked out in this environment (git submodule update --init failed with "No space left on device"), and the torch/gguf/sentencepiece Python packages this repo's converters import are not installed here either, so the full HF-to-GGUF pipeline could not be run end to end. To still validate by execution rather than inspection alone: - For convert-hf-to-gguf-bitnet.py: stubbed sys.modules for torch, sentencepiece, safetensors, and gguf (the gguf stub's MODEL_ARCH / GGMLQuantizationType return the attribute name for any access, and its GGUFWriter just records add_file_type's argument), loaded the real, unmodified utils/convert-hf-to-gguf-bitnet.py via importlib.util.spec_from_file_location, built a BitnetModel via object.__new__ with ftype set to the I2_S sentinel, and called the real Model.set_gguf_parameters() method on it. Before the fix this recorded file_type 40; after changing 40 to 41 in the source, rerunning the same harness recorded file_type 41. - For convert-bitnet-embedding-to-gguf.py: read the exact ftype-selection if/elif/else block out of the file at runtime and exec'd that extracted source text (unmodified from disk) with args.outtype = "i2_s"; the resulting ftype was 40 before the fix and 41 after. - python3 -m py_compile on both changed files passes. - Verified independently via the GitHub API that this repo's pinned llama.cpp submodule commit (390c307752ab78fd8189f359d6954c9ba1be74af) defines LLAMA_FTYPE_MOSTLY_Q1_0 = 40 and LLAMA_FTYPE_MOSTLY_I2_S = 41 in include/llama.h, confirming 41 is the correct value. Not run: the actual HF checkpoint -> GGUF conversion end to end, and llama-quantize/llama-cli against a real model (blocked by the submodule checkout failure above). Report: microsoft#619 Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com> Assisted-by: claude-sonnet-5 (via Claude Code)

microsoft-github-policy-service · 2026-09-05T09:49:29Z

Pujitha Paladugu (@pujitha24) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Claudio Aldrighetti (claudioaldrighettiatroos) mentioned this pull request Sep 6, 2026

convert-hf-to-gguf-bitnet.py --outtype i2_s silently writes F16 (not I2_S) for LlamaForCausalLM BitNet checkpoints (Falcon3 / Falcon-E 1.58bit) #621

Open

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

Fix wrong general.file_type value for I2_S GGUF conversion output - #620

Fix wrong general.file_type value for I2_S GGUF conversion output#620
Pujitha Paladugu (pujitha24) wants to merge 1 commit into
microsoft:mainfrom
pujitha24:auto/issue-619

Pujitha Paladugu (pujitha24) commented Sep 5, 2026

Uh oh!

microsoft-github-policy-service Bot commented Sep 5, 2026

Contribution License Agreement

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

Pujitha Paladugu (pujitha24) commented Sep 5, 2026

Uh oh!

microsoft-github-policy-service Bot commented Sep 5, 2026

Contribution License Agreement

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant