Fix send_timeout setter by sabbox · Pull Request #44 · microsoft/ApplicationInsights-Python · GitHub
Skip to content

Fix send_timeout setter#44

Merged
jjjordanmsft merged 2 commits into
microsoft:developfrom
sabbox:master
Sep 7, 2017
Merged

Fix send_timeout setter#44
jjjordanmsft merged 2 commits into
microsoft:developfrom
sabbox:master

Conversation

@sabbox

@sabbox sabbox commented Aug 15, 2017

Copy link
Copy Markdown
Contributor

SenderBase.send_timeout setter actually sets value to wrong field self._send_buffer_size = seconds

@msftclas

Copy link
Copy Markdown

@AlexBulankou AlexBulankou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jjjordanmsft jjjordanmsft changed the base branch from master to develop September 6, 2017 23:37
@jjjordanmsft jjjordanmsft merged commit 49d8862 into microsoft:develop Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants