Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (8a56be6) to head (565dda6).

@@           Coverage Diff           @@
##           master   #19138   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         176      176           
  Lines       22811    22811           
=======================================
  Hits        22460    22460           
  Misses        351      351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Code size report:

Reference:  extmod/moductypes: Be more defensive with uctypes_struct_agg_size args. [8a56be6]
Comparison: extmod: Place lwIP memory in a dedicated section. [merge of 565dda6]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
      esp32:    +0 +0.000% ESP32_GENERIC
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

I realized I can just override this from our custom mpconfigport.h so feel free to close it, however it might be useful for upstream boards with SDRAM.

If you can do it from mpconfigboard.h (or mpconfigport.h) then that would probably be best. Because it means we don't need to have the config option MICROPY_PY_LWIP_SECTION, and you'd have more control over how the LWIP macro is configured.

If you can do it from mpconfigboard.h (or mpconfigport.h)

Yes, it works from our custom mpconfigport.h, though it has to be added to every port that needs it. This is generic enough to be useful to any port/board, sure you don't want it? We don't actually have any board that uses this, but we do have extra DRAM.

I need to understand more, why is it actually needed, what is the reason to put it in a dedicated section?

I need to understand more, why is it actually needed, what is the reason to put it in a dedicated section?

So you can move it to another region, e.g., DRAM memory, and increase LWIP memory and buffers sizes.

.lwip_memory (NOLOAD) : ALIGN(4)
{
  *(.lwip)
  *(.lwip*)
  . = ALIGN(4);
} >DRAM