{{ message }}
nrf: Change all boards to use "nrf" for sys.platform value.#19135
Open
dpgeorge wants to merge 1 commit intomicropython:masterfrom
Open
nrf: Change all boards to use "nrf" for sys.platform value.#19135dpgeorge wants to merge 1 commit intomicropython:masterfrom
dpgeorge wants to merge 1 commit intomicropython:masterfrom
Conversation
The `sys.platform` variable on bare-metal ports is uniformly the port name (except for stm32 which uses "pyboard" for `sys.platform`), regardless of the board. Change the nrf port to follow this convention. Among other things, this gets the test auto-detection working properly on nrf boards, which relies on the value of `sys.platform` (eg for target wiring selection). Signed-off-by: Damien George <damien@micropython.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sys.platformvariable on bare-metal ports is uniformly the port name (except for stm32 which uses "pyboard" forsys.platform), regardless of the board.Change the nrf port to follow this convention.
Among other things, this gets the test auto-detection working properly on nrf boards, which relies on the value of
sys.platform(eg for target wiring selection).Testing
Tested on PCA10059, it now returns "nrf" for
sys.platform.Also, running
./run-tests -t a0 extmod/machine_s*.pyit now correctly detects the nrf port and uses the correct target wiring script (prior, it would just fail tests using target wiring with an ImportError fortarge_wiring.py).Trade-offs and Alternatives
This is a breaking change for the affected nrf boards, because it changes
sys.platformon them. But I doubt it's being used much and it should be easy enough to fix relevant Python code.This change will be prominently noted in the next release notes.
Generative AI
I did not use generative AI tools when creating this PR.