Repository navigation
docs: Add disable serving metrics info if port 0 - #416
Conversation
Signed-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
|
@mjsmith1028 I have some queries w.r.t changing the default behaviour of metrics. What issues do you face with current default metrics settings. It will be nice to stick to existing defaults (to avoid changes to all end user deployments) if it is not a bug. |
Hi @AmitKumarDas, I don't have any issues. I was just thinking to disable it by default because some users may not have prometheus setup. But, I agree that makes sense to leave it as is to avoid a breaking change if users are on the current default port 9999 👍 thanks! |
I was troubleshooting a couple things and wanted to disable prometheus metrics and came across the ability to disable it by setting the port to 0. See: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/manager/manager.go#L199
@grzesuav @AmitKumarDas I am thinking it might be better to default the value to 0 and have the user enable it if necessary. Thoughts?