fix: remove broken GRANT/REVOKE EXECUTE ON WORKFLOW by engalar · Pull Request #173 · mendixlabs/mxcli · GitHub
Skip to content

fix: remove broken GRANT/REVOKE EXECUTE ON WORKFLOW#173

Merged
ako merged 2 commits intomendixlabs:mainfrom
engalar:fix/grant-workflow-security-location
Apr 11, 2026
Merged

fix: remove broken GRANT/REVOKE EXECUTE ON WORKFLOW#173
ako merged 2 commits intomendixlabs:mainfrom
engalar:fix/grant-workflow-security-location

Conversation

@engalar
Copy link
Copy Markdown
Contributor

@engalar engalar commented Apr 10, 2026

Summary

  • GRANT/REVOKE EXECUTE ON WORKFLOW silently wrote an AllowedModuleRoles field on the Workflow BSON document, but Workflows$Workflow has no such field in the Mendix metamodel (confirmed by generated metamodel types and BSON dump of Studio Pro output). Studio Pro ignored the phantom field entirely.
  • Replaced the broken executor implementations with clear error messages explaining that workflow access is controlled through triggering microflows and UserTask targeting, not document-level roles.
  • Removed the AllowedModuleRoles field from the Workflow struct and its BSON parser, and cleaned up SHOW SECURITY MATRIX workflow section, HELP output, and all documentation references.

Test plan

  • make build succeeds
  • make test passes
  • GRANT EXECUTE ON WORKFLOW Mod.WF TO Mod.Role; returns clear error message
  • Verify no regression in microflow/page GRANT/REVOKE (those still use AllowedModuleRoles correctly)

@github-actions
Copy link
Copy Markdown

Workflows$Workflow has no AllowedModuleRoles field in the Mendix metamodel
(confirmed by generated metamodel and BSON dump of Studio Pro output). The
GRANT/REVOKE EXECUTE ON WORKFLOW commands silently wrote a phantom field
that Studio Pro ignored. Replace with clear error messages explaining that
workflow access is controlled through triggering microflows and UserTask
targeting.
@engalar engalar force-pushed the fix/grant-workflow-security-location branch from bff460a to 88eaa78 Compare April 10, 2026 11:23
…HELP

- Remove SHOW ACCESS ON WORKFLOW from HELP output
- Update workflows.md See Also to clarify access control approach
- Remove dead Workflow section from showSecurityMatrix (AllowedModuleRoles doesn't exist)
@ako ako merged commit 9e83ea7 into mendixlabs:main Apr 11, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants