{{ message }}
Repository navigation
fix: no-panic temporal phrase resolution - #251
Open
joshuaclayton wants to merge 1 commit into
Open
joshuaclayton wants to merge 1 commit into
joshuaclayton wants to merge 1 commit into
Conversation
Date arithmetic in the temporal resolver (add_days, month offsets, combine) could panic on out-of-range results. Make the resolution helpers return Option and propagate None instead, so a pathological phrase or anchor date degrades to 'no resolution' rather than a panic in library code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date arithmetic in the temporal resolver panics on out-of-range inputs:
add_daysischecked_add(...).unwrap(), and several resolvers build dates withDate::from_calendar_date(...).unwrap(). A phrase resolved against an anchor date near the edge of the representable range panics inside library code.This changes the resolution helpers to return
Optionand propagateNone, so those inputs degrade to no resolution instead of a panic. Inputs that resolved before resolve to the same values; 342 lib tests pass withtemporal_trackenabled.