{{ message }}
Repository navigation
Conversation
The README Quick Start example uses struct-update syntax (..Default::default()) when constructing a SearchRequest, but the type had no Default implementation, causing a compile error (E0277) for users following the guide. Add an explicit Default impl with sensible values: - query: empty string (callers override with their query) - top_k: 10 - snippet_chars: 200 - all optional / flag fields: None / false / enum default Fixes: memvid#221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The Quick Start example in README uses struct-update syntax when constructing a
SearchRequest:However,
SearchRequestdoes not implementDefault, so this code fails to compile with:Reported in #221.
Fix
Add an explicit
Defaultimplementation forSearchRequestwith sensible values:query: emptyString(callers override via struct-update)top_k:10snippet_chars:200None/false/ enum defaultsThis makes the README Quick Start compile without changes, and gives library users the ergonomic struct-update pattern they already expect.
Testing
The change is purely additive — a new
impl Defaultblock. Existing code is unaffected. The fix can be verified with: