{{ message }}
Add AttributeRank and WordPosition to ranking criteria#6190
Open
Shabhareash wants to merge 5 commits intomeilisearch:mainfrom
Open
Add AttributeRank and WordPosition to ranking criteria#6190Shabhareash wants to merge 5 commits intomeilisearch:mainfrom
Shabhareash wants to merge 5 commits intomeilisearch:mainfrom
Conversation
Member
Author
|
Sure , I just have a little work , will fix it by EOD
…On Wed, 11 Mar 2026, 16:03 Many the fish, ***@***.***> wrote:
*ManyTheFish* left a comment (meilisearch/meilisearch#6190)
<#6190 (comment)>
Hello @Shabhareash <https://github.com/Shabhareash>,
Your PR seems good enough. Could you fix the tests, please?
This way, we can merge your work!
Thank you!
—
Reply to this email directly, view it on GitHub
<#6190 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4IOFDVCV4N3RIT6CYD3ENT4QE6JDAVCNFSM6AAAAACWDNOJSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMZYGE4TKMJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Hey @Shabhareash 👋 Would you mind mixing the last little issues in the CI, please? |
Author
|
Yeah, I can do that. This is like my first PR so kindly bear with me.
…On Thu, 12 Mar 2026 at 22:57, Clément Renault ***@***.***> wrote:
*Kerollmops* left a comment (meilisearch/meilisearch#6190)
<#6190 (comment)>
Hey @Shabhareash <https://github.com/Shabhareash> 👋 Would you mind
mixing the last little issues in the CI, please?
—
Reply to this email directly, view it on GitHub
<#6190 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4IOFDU4Z34DPJ4YQQLFB434QLXRNAVCNFSM6AAAAACWDNOJSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANBYGYYTONBRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Removed unused criteria 'AttributeRank' and 'WordPosition' from the match statement.
When AttributeRank or WordPosition was placed before Words in the ranking rules, the Words rule was never auto-inserted. This prevented TermsMatchingStrategy from removing query words to find more results, causing fewer hits to be returned. Adds regression tests to verify the fix.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #6185
imp : Could a maintainer please add the
no db changelabel? This PR contains no database changes. (my first PR i forgot sorry)What does this PR do?
Fixes a bug where placing
attributeRankorwordPositionbefore thewordsranking rule would prevent the
Wordsrule from being auto-injected, causingonly documents matching ALL query terms to be returned instead of also returning
partial matches.
Added
AttributeRankandWordPositionto the match arm inget_ranking_rules_for_query_graph_searchthat auto-inserts the Words ranking rule.Requirements
--experimental-dumpless-upgradeon a DB created with the last released Meilisearchdb changelabel.