{{ message }}
Repository navigation
Conversation
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Title: [Technical review] Add BiDi network pages:
addIntercept,continueRequest,failRequest,removeInterceptDescription
networkmodule:network.addInterceptnetwork.continueRequestnetwork.failRequestnetwork.removeInterceptnetworkmodule landing page.The pages link to the event pages from #46141 and to
network.setExtraHeadersfrom #46140, so this PR should merge after those two.Every example was run against Firefox Nightly 159 and Chrome 155 (through ChromeDriver) with a local server.
Spec links
Related issue
Doc issue: mdn/mdn#851
Compat quirks worth looking into:
continueRequestparameters in Firefox. All three come from my test run:url: for afetch(), the rewritten request reaches the new URL and the events report a 200 from it, but the page'sfetch()rejects withAbortError: The operation was aborted.A navigation with a rewritten URL works. BCD shows Firefox'surlparameter as supported since 133. cc @whimboo for the compat sheet update.headers: Firefox sends only the headers in the list, so a list withoutHostproduces a request with noHostheader (my server answered 400). Chrome still sendsHost,Cookie,User-Agentand its other network headers. BCD shows Firefox'sheadersparameter as supported. cc @whimboo for the compat sheet update.body: with a longer body for a POST request, Firefox keeps the originalContent-Length, so the server receives a truncated body. Chrome sends the new length. BCD shows Firefox'sbodyparameter as supported. cc @whimboo for the compat sheet update.