{{ message }}
Enhance type classification and simplify numeric conversion functions - #16
Merged
Conversation
…g_operand concept
…move unused error handling functions
…ric casting integration
…bility in casting
…ssment and type traits
…ng and casting safety
… numeric conversion
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new conversion submodule to centralize numeric/underlying casting helpers, expands type classification concepts (e.g., *_like), and updates exports/imports so downstream code can consume the new conversion APIs.
Changes:
- Add
mcpplibs.primitives.conversion(traits + underlying casting utilities) and export it from the umbrellamcpplibs.primitivesmodule. - Refine type concepts by adding operand/“*_like” concepts to better accept primitives and/or underlying types.
- Replace legacy numeric casting helpers with the new conversion utilities and add new unit tests for conversions.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR changes: