fix: don't duplicate field-level ops when filtering by child array path (v0.17.2) by maxjay · Pull Request #36 · maxjay/patchwork · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
13 changes: 13 additions & 0 deletions src/engine.array-semantics.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -573,4 +573,17 @@ describe('diff — includeUnchanged propagation into nested keyed arrays', () =>
expect(ops).toHaveLength(1);
expect(ops[0]).toMatchObject({ op: OpType.Unchanged, identity: 'DELTA' });
});

it('field change on one child: returns one Replace op for that child — not a duplicate field-level op', () => {
const e = makeOrdersEngine();
e.replace('$.items[0].children[1].qty', 99); // change BETA's qty
const ops = e.diff("$.items[0].children", { includeUnchanged: true });
// Expect exactly one op per child — no field-level replace leaking out alongside the element Replace
expect(ops).toHaveLength(3);
const betaOp = ops.find((o: any) => o.identity === 'BETA');
expect(betaOp).toBeDefined();
expect(betaOp!.op).toBe(OpType.Replace);
expect((betaOp as any).changes).toHaveLength(1); // field-level replace lives inside .changes
expect(ops.filter(o => o.op === OpType.Replace)).toHaveLength(1); // not duplicated at top level
});
});
23 changes: 14 additions & 9 deletions src/engine.ts
Loading