Skip to content
Navigation Menu
{{ message }}
forked from jgraph/mxgraph
-
Notifications
You must be signed in to change notification settings - Fork 201
refactor: introduce AbstractPathShape base class for shape hierarchy #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
97cc2c2
refactor: introduce AbstractPathShape base class for shape hierarchy
tbouffard b6fc482
AbstractPathShape.ts: fix jsdoc
tbouffard 0344fd3
ActorShape: improve jsdoc
tbouffard fb497a6
Merge branch 'main' into refactor/ActorShape
tbouffard 8590896
remove extra constructors
tbouffard f0c0aa8
make AbstractPathShape constructor public to allow to construct subcl…
tbouffard 59aaf02
fix jsdoc [skip ci]
tbouffard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| Copyright 2021-present The maxGraph project Contributors | ||
| Copyright (c) 2006-2015, JGraph Ltd | ||
| Copyright (c) 2006-2015, Gaudenz Alder | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| import type Rectangle from '../../geometry/Rectangle.js'; | ||
| import Shape from '../Shape.js'; | ||
| import type AbstractCanvas2D from '../../canvas/AbstractCanvas2D.js'; | ||
| import type { ColorValue } from '../../../types.js'; | ||
| import { NONE } from '../../../util/Constants.js'; | ||
|
|
||
| /** | ||
| * Base {@link Shape} for vertex shapes rendered from a single path. | ||
| * | ||
| * If a custom shape with one filled area is needed, override {@link redrawPath} as in the following example: | ||
| * | ||
| * ```typescript | ||
| * class SampleShape extends AbstractPathShape { | ||
| * redrawPath(c: AbstractCanvas2D, x: number, y: number, w: number, h: number) { | ||
| * c.moveTo(0, 0); | ||
| * c.lineTo(w, h); | ||
| * // ... | ||
| * c.close(); | ||
| * } | ||
| * } | ||
| * ``` | ||
| * | ||
| * @category Vertex Shapes | ||
| */ | ||
| export abstract class AbstractPathShape extends Shape { | ||
| constructor( | ||
| bounds: Rectangle | null = null, | ||
| fill: ColorValue = NONE, | ||
| stroke: ColorValue = NONE, | ||
| strokeWidth = 1 | ||
| ) { | ||
| super(); | ||
| this.bounds = bounds; | ||
| this.fill = fill; | ||
| this.stroke = stroke; | ||
| this.strokeWidth = strokeWidth; | ||
| } | ||
|
|
||
| /** | ||
| * Redirects to redrawPath for subclasses to work. | ||
| */ | ||
| override paintVertexShape( | ||
| c: AbstractCanvas2D, | ||
| x: number, | ||
| y: number, | ||
| w: number, | ||
| h: number | ||
| ) { | ||
| c.translate(x, y); | ||
| c.begin(); | ||
| this.redrawPath(c, x, y, w, h); | ||
| c.fillAndStroke(); | ||
| } | ||
|
|
||
| /** | ||
| * Draws the path for this shape. | ||
| */ | ||
| abstract redrawPath( | ||
| c: AbstractCanvas2D, | ||
| x: number, | ||
| y: number, | ||
| w: number, | ||
| h: number | ||
| ): void; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

Uh oh!
There was an error while loading. Please reload this page.