{{ message }}
chore: use stricter options with the TS compiler#922
Merged
Conversation
tbouffard
added
the
chore
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tsconfig.json (1)
11-14: Avoid redundant flags: noImplicitAny and noImplicitThis are already implied by "strict": trueKeeping them is harmless but duplicate. noImplicitReturns is the only new check here. If you prefer a leaner config, remove the redundancies.
- "noImplicitAny": true, "noImplicitOverride": true, "noImplicitReturns": true, - "noImplicitThis": true,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/core/src/gui/MaxLog.ts(1 hunks)packages/core/src/util/logger.ts(1 hunks)tsconfig.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: tbouffard
PR: maxGraph/maxGraph#849
File: packages/html/stories/DragSource.stories.js:98-101
Timestamp: 2025-06-13T07:48:10.300Z
Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.
🔇 Additional comments (2)
packages/core/src/util/logger.ts (1)
62-68: Explicit undefined return to satisfy noImplicitReturns — LGTMMatches the declared signature and keeps control flow clear when tracing is disabled.
packages/core/src/gui/MaxLog.ts (1)
271-277: Consistent explicit undefined return — LGTMAligns with ConsoleLogger.enter and satisfies noImplicitReturns without changing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Refactor
Chores