{{ message }}
refactor!: remove unused domUtils.importNodeImplementation#648
Merged
tbouffard merged 2 commits intoJan 28, 2025
Merged
Conversation
In mxGraph, it was only used at a single place to "support older versions of IE". https://github.com/jgraph/mxgraph/blob/ff141aab158417bd866e2dfebd06c61d40773cd2/javascript/src/js/util/mxSvgCanvas2D.js#L1270 BREAKING CHANGES: this function has been removed because it was unused. It was only used internally in `mxGraph` and should not have been exposed.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
19-19: Enhance the changelog entry with more details.The breaking change entry should follow the same format as other entries and provide more context for users. Consider the following improvements:
-- `domUtils.importNodeImplementation` has been removed because it was unused. It was only used internally in `mxGraph` and should not have been exposed. +- `domUtils.importNodeImplementation` has been removed: + - This function was only used internally in `mxGraph` to support older versions of IE + - It was not intended to be part of the public API + - No migration steps are needed as the function was unused
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)packages/core/src/util/domUtils.ts(0 hunks)
💤 Files with no reviewable changes (1)
- packages/core/src/util/domUtils.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (windows-2022)
tbouffard
deleted the
refactor/remove_unused_domUtils_importNodeImplementation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mxGraph, it was only used at a single place to "support older versions of IE".
https://github.com/jgraph/mxgraph/blob/ff141aab158417bd866e2dfebd06c61d40773cd2/javascript/src/js/util/mxSvgCanvas2D.js#L1270
BREAKING CHANGES: this function has been removed because it was unused.
It was only used internally in
mxGraphand should not have been exposed.Summary by CodeRabbit
importNodeImplementationfunction for clarity.EdgeHandlerproperties with more descriptive global configurations.importNodemethod.