docs: mention examples in the documentation introduction by tbouffard · Pull Request #585 · maxGraph/maxGraph · GitHub
Skip to content

docs: mention examples in the documentation introduction#585

Merged
tbouffard merged 1 commit into
mainfrom
docs/ref_examples
Nov 24, 2024
Merged

docs: mention examples in the documentation introduction#585
tbouffard merged 1 commit into
mainfrom
docs/ref_examples

Conversation

@tbouffard

@tbouffard tbouffard commented Nov 24, 2024

Copy link
Copy Markdown
Member

Notes

Try to prevent newcomers from getting an impression as in #584

"The documentation lacks complete examples."

Summary by CodeRabbit

  • Documentation
    • Updated the documentation for the maxGraph library with a new "Quick Start" section, highlighting available examples and providing links to a live demo and source code.

@tbouffard tbouffard added the documentation Improvements or additions to documentation label Nov 24, 2024
@coderabbitai

coderabbitai Bot commented Nov 24, 2024

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
packages/website/docs/intro.md (2)

54-63: Great addition that addresses the documentation feedback!

The new tip section effectively addresses the feedback about examples and provides multiple helpful resources. The content is well-structured and valuable for newcomers.

Consider enhancing the URL presentation on line 59 with more descriptive link text:

-- Source code for the stories is available at https://github.com/maxGraph/maxGraph/blob/main/packages/html/stories
+- Source code for the stories is available in the [examples directory](https://github.com/maxGraph/maxGraph/blob/main/packages/html/stories)
🧰 Tools
🪛 Markdownlint (0.35.0)

59-59: null
Bare URL used

(MD034, no-bare-urls)


59-59: Fix Markdown linting issue: Convert bare URL to proper link format

The bare URL triggers the MD034 (no-bare-urls) rule. Using proper Markdown link syntax improves readability and follows Markdown best practices.

Apply this change:

-- Source code for the stories is available at https://github.com/maxGraph/maxGraph/blob/main/packages/html/stories
+- Source code for the stories is available at [https://github.com/maxGraph/maxGraph/blob/main/packages/html/stories](https://github.com/maxGraph/maxGraph/blob/main/packages/html/stories)
🧰 Tools
🪛 Markdownlint (0.35.0)

59-59: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0137167 and 1e547c2.

📒 Files selected for processing (1)
  • packages/website/docs/intro.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.35.0)
packages/website/docs/intro.md

59-59: null
Bare URL used

(MD034, no-bare-urls)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant