iframe-proxy

redfish4ktc · 2026-05-27T09:48:04Z

Summary

Replace the four repetitive Object.defineProperty blocks (one per container dimension) with a single loop iterating over Object.entries(dimensions).
Reduces duplication in the test helper that sets up container dimensions, removing 21 lines while keeping behavior identical.

Test plan

npm test -w packages/core -- FitPlugin.test (17 tests pass)

Summary by CodeRabbit

Tests
- Refactored a test helper that sets container dimensions for cleaner implementation; behavior unchanged — falsy numeric inputs (e.g., 0) remain skipped during testing.

Replace repetitive Object.defineProperty calls with a loop to reduce code duplication when setting up container dimensions in tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-05-27T09:48:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f1836590-65e4-42ac-a70b-a93ded992461

📥 Commits

Reviewing files that changed from the base of the PR and between 8d47145 and da9e10d.

📒 Files selected for processing (1)

packages/core/__tests__/view/plugin/FitPlugin.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

packages/core/tests/view/plugin/FitPlugin.test.ts

Walkthrough

The FitPlugin test helper's createContainer is changed to iterate over dimensions entries and call Object.defineProperty for each entry; properties are defined only when the entry value is truthy, so falsy numeric inputs like 0 are still skipped.

Changes

FitPlugin test helper refactoring

Layer / File(s)	Summary
createContainer dimension property definition refactoring `packages/core/__tests__/view/plugin/FitPlugin.test.ts`	Replaces per-field truthy-guarded `Object.defineProperty` calls with a single `Object.entries(dimensions)` loop that defines each property only when the entry value is truthy (falsy numeric values such as `0` remain skipped).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

maxGraph/maxGraph#834: Both PRs modify the FitPlugin test helper createContainer in the FitPlugin test suite to define container dimension properties via Object.defineProperty.

Suggested labels

chore

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description provides a clear summary of changes and test results, but is missing most required PR checklist items from the template.	Complete the PR checklist by addressing: linked issue number, scope confirmation, screenshot/video evidence, documentation changes, and Conventional Commits verification.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: simplifying container dimension setup in the FitPlugin test helper by refactoring repetitive code into a loop.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2026-05-27T10:35:32Z

test(FitPlugin): simplify container setup with loop

8d47145

Replace repetitive Object.defineProperty calls with a loop to reduce code duplication when setting up container dimensions in tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

redfish4ktc added the refactor Code refactoring label May 27, 2026

add guard for undefined value to restore the former behavior

da9e10d

redfish4ktc merged commit 7f2e169 into main May 27, 2026
14 checks passed

redfish4ktc deleted the test/simplify_FitPlugin.test branch May 27, 2026 12:13

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(FitPlugin): simplify container dimension setup#1079

test(FitPlugin): simplify container dimension setup#1079
redfish4ktc merged 2 commits into
mainfrom
test/simplify_FitPlugin.test

redfish4ktc commented May 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 27, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented May 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

redfish4ktc commented May 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented May 27, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

redfish4ktc commented May 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 27, 2026 •

edited

Loading