Remove tab in Makefile making it build again by ntolazzi · Pull Request #185 · matrix-org/matrix-python-sdk · GitHub
Skip to content

Remove tab in Makefile making it build again#185

Merged
non-Jedi merged 1 commit into
matrix-org:masterfrom
ntolazzi:fix_Makefile
Mar 28, 2018
Merged

Remove tab in Makefile making it build again#185
non-Jedi merged 1 commit into
matrix-org:masterfrom
ntolazzi:fix_Makefile

Conversation

@ntolazzi

@ntolazzi ntolazzi commented Mar 28, 2018

Copy link
Copy Markdown
Contributor

There was a tab in line 12 of the Makefile leading to the following error message when executing make:

commence before first target. Stop.

The tab was removed.

Signed-off-by: Nicolas Tolazzi nicolas.tolazzi@googlemail.com

@non-Jedi

Copy link
Copy Markdown
Collaborator

@non-Jedi

Copy link
Copy Markdown
Collaborator

Nevermind. I see it. This happens iff sphinx-build isn't installed. Thanks for the patch! I know it seems silly, but could you sign-off per CONTRIBUTING.rst? Thanks!

@ntolazzi

Copy link
Copy Markdown
Contributor Author

Not so sure whether I did the signing-off it correctly. I added the line to my initial comment, is that right?

@non-Jedi

Copy link
Copy Markdown
Collaborator

@non-Jedi non-Jedi merged commit 0bf05ac into matrix-org:master Mar 28, 2018
@ntolazzi ntolazzi deleted the fix_Makefile branch March 28, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants