{{ message }}
Set deterministic to True for vector graphics and warn about change to True in future for PNG#197
Merged
Conversation
Member
Member
|
I see the changes in this PR are already in the documentation (https://pytest-mpl.readthedocs.io/en/latest/configuration.html#whether-to-make-metadata-deterministic) so we should merge this before releasing |
Collaborator
Author
|
@ConorMacBride - I don't have time to work on the CLI and ini options now but if you do, feel free to push to this PR. Otherwise we could just merge without as you said. |
…o True in future for PNG
ConorMacBride
force-pushed
the
deterministic-default
branch
from
2e81f56 to
79b8fe5
Compare
ConorMacBride
force-pushed
the
deterministic-default
branch
from
1d4e83c to
efc9f33
Compare
Member
|
@astrofrog I've added the CLI and INI options here: https://pytest-mpl--197.org.readthedocs.build/en/197/configuration.html#whether-to-make-metadata-deterministic If this looks okay, feel free to merge. I'll then go ahead and release |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on this I started to wonder if this should be a kwarg at all for mpl_image_compare or just a CLI/ini option. Any opinions?