Started implementing support for deterministic figure output by astrofrog · Pull Request #196 · matplotlib/pytest-mpl · GitHub
Skip to content

Started implementing support for deterministic figure output#196

Merged
astrofrog merged 8 commits into
matplotlib:mainfrom
astrofrog:deterministic-option
Apr 3, 2023
Merged

Started implementing support for deterministic figure output#196
astrofrog merged 8 commits into
matplotlib:mainfrom
astrofrog:deterministic-option

Conversation

@astrofrog

Copy link
Copy Markdown
Collaborator

This is a work in progress and not ready for review

@astrofrog astrofrog force-pushed the deterministic-option branch from 1589f8a to 95d4b9d Compare April 1, 2023 08:09
@astrofrog astrofrog force-pushed the deterministic-option branch from 67e3260 to 8b83298 Compare April 1, 2023 08:39
@astrofrog astrofrog marked this pull request as ready for review April 1, 2023 09:33
@astrofrog

Copy link
Copy Markdown
Collaborator Author

@ConorMacBride ConorMacBride left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! I think this definitely should be the default. There are some other breaking changes I think should be made to make the plugin less sensitive and easier to manage, particularly for new users: use the default matplotlib style, merge the perceptual hashing and make it the default hash type when generating a new library, and maybe review some of the ini, cli and decorator settings for consistency. We could start preparing for a v1.0.0 in a new branch. What do you think?

@astrofrog astrofrog changed the title Started implementing support for determinstic figure output Started implementing support for deterministic figure output Apr 3, 2023
@astrofrog

astrofrog commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator Author

@ConorMacBride - thanks for reviewing! I'm a little uncertain how we should approach breaking changes at this point (in the sense that we would still break a lot of CI/testing in existing packages, so perhaps we need to batch open issues to repos using the plugin), but of the changes you mention I agree that if we could make breaking changes, then switching the default Matplotlib style would be good. Perhaps also changing the default tolerance to 0. However I'm not sure about making perceptual hashes the default, I still feel that should probably be opt-in? In any case perhaps we could open a new issue to discuss it?

@astrofrog astrofrog merged commit e6c1308 into matplotlib:main Apr 3, 2023
@astrofrog

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check whether any updates are needed following Matplotlib changes

2 participants