Add RTD config by ConorMacBride · Pull Request #195 · matplotlib/pytest-mpl · GitHub
Skip to content

Add RTD config#195

Merged
ConorMacBride merged 5 commits into
matplotlib:mainfrom
ConorMacBride:rtd
Apr 1, 2023
Merged

Add RTD config#195
ConorMacBride merged 5 commits into
matplotlib:mainfrom
ConorMacBride:rtd

Conversation

@ConorMacBride

Copy link
Copy Markdown
Member

No description provided.

@ConorMacBride ConorMacBride force-pushed the rtd branch 6 times, most recently from 35138aa to dbf39d5 Compare March 31, 2023 14:23
Comment thread .readthedocs.yaml Outdated
Comment thread .readthedocs.yaml Outdated
Comment thread .readthedocs.yaml Outdated
Comment thread docs/rtd_environment.yaml Outdated

@ConorMacBride ConorMacBride left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove all the conda stuff. Just copied the config from astropy or sunpy 😄

@astrofrog

Copy link
Copy Markdown
Collaborator

@astrofrog

Copy link
Copy Markdown
Collaborator

But do we actually need graphviz here?

@astrofrog

Copy link
Copy Markdown
Collaborator

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of pushing a few commits to simplify the config, hope that's ok! I think we could merge this now assuming the CI passes.

Some of the boxes on the front page of the docs are empty but that's unrelated to this PR which is just fixing the config.

Maybe we don't have to use this template if our content doesn't quite fit in?

@ConorMacBride ConorMacBride merged commit d5ed60c into matplotlib:main Apr 1, 2023
@ConorMacBride ConorMacBride deleted the rtd branch April 1, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants