{{ message }}
Shadow patch now initializes zorder behind argument patch - #9435
Merged
Merged
Conversation
Contributor
Member
|
@afvincent I guess I was also worried about the transform issue in #9426 but maybe both can be finessed without an actual image test? But sure, just checking that the zorders are ordered properly is great! |
Contributor
|
I think that the best way is (as mentioned in a few other places) to have an "as if" test: generate figure 1 with the shadow created before the rectangle is added (the previously failing case) and figure 2 with two manually positioned rectangles with the correct zorder and correct positions. It's a bit tricky to write though and I'm fine with taking care of it in #9426 (after this PR gets merged). |
dstansby
approved these changes
Oct 19, 2017
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When initializing a
patch.Shadowinstance the object inherits the same zorder as the passed patch. This behavior draws the two patches in the same plane. This PR initializes thepatch.Shadowto take the next smallerzorderby default.This fixes an issue about zorder stacking for Shadow patches referenced here: #9377
PR Checklist