changed default values of Axes.specgram() by andreh7 · Pull Request #9221 · matplotlib/matplotlib · GitHub
Skip to content

changed default values of Axes.specgram() - #9221

Closed
andreh7 wants to merge 1 commit into
matplotlib:masterfrom
andreh7:2017-08-specgram-docstring-default-values
Closed

andreh7 wants to merge 1 commit into
matplotlib:masterfrom
andreh7:2017-08-specgram-docstring-default-values

Conversation

@andreh7

@andreh7 andreh7 commented Sep 25, 2017

Copy link
Copy Markdown

as proposed in #9100 (comment)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jklymak

jklymak commented Sep 25, 2017

Copy link
Copy Markdown
Member

@dstansby

Copy link
Copy Markdown
Member

(FWIW I think eventually mlab.specgram should disappear and be replaced by https://docs.scipy.org/doc/scipy-0.17.0/reference/generated/scipy.signal.spectrogram.html since Matplotlib is really a plotting library and not a spectral analysis library)

@anntzer

anntzer commented Nov 28, 2017

Copy link
Copy Markdown
Contributor

pyplot would need to be regenerated too (or #9173 merged :-)). And I agree that the whole thing should be deprecated anyways.

@jklymak

jklymak commented Apr 24, 2018

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants