{{ message }}
Changed normalization in _spectral_helper() to obtain conistent scaling - #8582
Merged
Conversation
…ng in magnitude_spectrum() and fixed doc string.
dstansby
approved these changes
May 14, 2017
dstansby
left a comment
dstansby
left a comment
Member
There was a problem hiding this comment.
Looks good to me - is there any reason we're running our own FFT code and not just using scipy? (I presume because we don't want scipy as a dependency)
Contributor
Author
Member
|
1) mlab.py predates scipy and 2) yes, we have a strict rule on not
depending upon advanced packages such as scipy.
This rule was originally born of the need to keep the installation as
simple as possible, however it has also been a good way to help keep
matplotlib's scope in check. Yes, there are some legacy code where we are
doing some advanced things that we probably shouldn't, but they remain in
the codebase strictly for legacy reasons. It would be hard to remove that
functionality now since it has been present for so long.
…On Sun, May 14, 2017 at 3:07 PM, Dietrich Brunn ***@***.***> wrote:
As far as I understood it, the reason for having our own implementation is
that the FORTRAN code in SciPy is making installation cumbersome under
windows.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8582 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-HHvQFwHSWD_KuZoQkM1L2JfRrCaks5r51DhgaJpZM4NS3bY>
.
|
Member
|
Is there any way to recover the previous behavior? |
tacaswell
requested changes
Jun 9, 2017
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
Can you please add a note to https://github.com/matplotlib/matplotlib/tree/master/doc/api/api_changes ?
Contributor
Author
|
@tacaswell I added an example to the api_changes on how to obtain the old behavior. I don't think it makes sense to add option to the function, since the original behavior is inconsistent (different window functions make different scalings). |
tacaswell
approved these changes
Jun 12, 2017
Member
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8417.
Also a docstring of
axes.magnitude_spectrum()is updated since it has no parameterscaling.