{{ message }}
Legend hatching fixes - #8575
Merged
Merged
Conversation
This ensures that additional settings like hatch colours get set up properly.
Member
tacaswell
approved these changes
May 6, 2017
Member
tacaswell
modified the milestones:
2.0.3 (next bug fix release),
2.0.2 (critical bug fixes from 2.0.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for hatching in legends:
PolyCollections don't show hatching when the default colour is used. This is because the set edge colour is copied which means the default behaviour of finding the hatch colour fromrcParamsis not done. Instead copy the "original" edge colour which triggers any other processing when setting the edge colour on the legend patch.Patchs show the wrong colour when an explicit one is set; this is simply because the hatching colour is not copied with other settings.I added tests for both these types of artists; are there any others that might work differently that should be added?