Fixed GraphicsContextBase linestyle getter by Kojoley · Pull Request #7730 · matplotlib/matplotlib · GitHub
Skip to content

Fixed GraphicsContextBase linestyle getter - #7730

Merged
NelleV merged 1 commit into
matplotlib:masterfrom
Kojoley:fix-linestyle-getter
Jan 13, 2017
Merged

NelleV merged 1 commit into
matplotlib:masterfrom
Kojoley:fix-linestyle-getter

Conversation

@Kojoley

@Kojoley Kojoley commented Jan 2, 2017

Copy link
Copy Markdown
Member

Closes #3354

@Kojoley Kojoley added this to the 2.1 (next point release) milestone Jan 2, 2017
@tacaswell

Copy link
Copy Markdown
Member

@tacaswell tacaswell added API: changes Changes to the public API, typically requiring deprecation. API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … and removed API: changes Changes to the public API, typically requiring deprecation. labels Jan 3, 2017
@Kojoley

Kojoley commented Jan 3, 2017

Copy link
Copy Markdown
Member Author

GraphicsContextBase.get_linestyle is not used anywhere in mpl code.
GraphicsContextBase._linestyle is used only in GraphicsContextBase.copy_properties and it sets the variable DIRECTLY.
GraphicsContextBase.set_linestyle is used only in one place and overridden only in wx backend.
There is a TODO entry in pdf backend about _linestyle from 2006 year and I am not sure it makes any sense now.

So I assume it is safe to fix this without deprecation (or even to remove the property).

@anntzer

anntzer commented Jan 8, 2017

Copy link
Copy Markdown
Contributor

If we're going to break backcompat, let's just remove the property?

@tacaswell tacaswell closed this Jan 9, 2017
@tacaswell tacaswell reopened this Jan 9, 2017
@tacaswell

Copy link
Copy Markdown
Member

power cycled to run CI with fixes from master branch to other tests.

@codecov-io

codecov-io commented Jan 9, 2017

Copy link
Copy Markdown

Current coverage is 62.52% (diff: 100%)

Merging #7730 into master will increase coverage by 0.40%

@@             master      #7730   diff @@
==========================================
  Files           174        174          
  Lines         56028      56703   +675   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34805      35453   +648   
- Misses        21223      21250    +27   
  Partials          0          0          

Powered by Codecov. Last update 8279f64...0980bc5

@anntzer anntzer mentioned this pull request Jan 9, 2017
@NelleV

NelleV commented Jan 13, 2017

Copy link
Copy Markdown
Member

@NelleV
NelleV merged commit 26a30ce into matplotlib:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, …

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants