{{ message }}
Fixed GraphicsContextBase linestyle getter - #7730
Merged
Merged
Conversation
Member
Member
Author
|
So I assume it is safe to fix this without deprecation (or even to remove the property). |
Contributor
|
If we're going to break backcompat, let's just remove the property? |
Member
|
power cycled to run CI with fixes from master branch to other tests. |
Current coverage is 62.52% (diff: 100%)@@ master #7730 diff @@
==========================================
Files 174 174
Lines 56028 56703 +675
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34805 35453 +648
- Misses 21223 21250 +27
Partials 0 0
|
tacaswell
approved these changes
Jan 9, 2017
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #3354