{{ message }}
Add xkcd font as one of the options - #6811
Merged
Merged
Conversation
The official xkcd font https://github.com/ipython/xkcd-font was missing from the list of what is looked for when the user selects xkcd mode. Since it is the "official" font, it has been added to the top of the list.
Member
Closed
Member
|
This should probably also be added to https://github.com/matplotlib/matplotlib/blob/master/matplotlibrc.template#L209 and rcsetup https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/rcsetup.py#L1002 |
Contributor
Author
|
I installed the font in my |
Member
|
Yes please. |
| validate_stringlist], | ||
| 'font.fantasy': [['Comic Sans MS', 'Chicago', 'Charcoal', 'Impact' | ||
| 'Western', 'Humor Sans', 'fantasy'], | ||
| 'Western', 'Humor Sans', 'fantasy, xkcd'], |
Member
There was a problem hiding this comment.
This looks wrong, are there missing '' here?
Contributor
Author
There was a problem hiding this comment.
Hopefully build servers pick that one up.
tacaswell
added a commit
that referenced
this pull request
Jul 23, 2016
ENH: Add xkcd font as one of the options in xkcd style
Member
|
Backported to 2.x as 8751f9b Thanks @peterfpeterson |
Member
|
Hmm, isn't |
Member
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 16, 2016
cf. last comments on matplotlib#6811.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official xkcd font https://github.com/ipython/xkcd-font
was missing from the list of what is looked for when the
user selects xkcd mode. Since it is the "official" font, it
has been added to the top of the list.