{{ message }}
Remove a copy in pcolormesh. - #6677
Merged
Merged
Conversation
This slightly increases the size of the maximum pcolormesh before
hitting a MemoryError. Test with
N = 6000; x, y = mgrid[:N, :N]; z = sin(x + y); pcolormesh(x, y, z)
The patch raises the maximum N to ~8000 on my system (depending on the
load).
OTOH, this probably(?) makes pcolormesh sensitive to later changes in
the input array.
Member
Contributor
Author
|
On coordinates or on the data as well? |
Member
|
Yes, it seems to me that double precision is overkill for coordinates and for data, in almost all plotting situations. The question then is whether it is worth the trouble--and if so, when--to convert to single precision. |
NelleV
approved these changes
Oct 11, 2016
NelleV
changed the title
Member
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slightly increases the size of the maximum pcolormesh before
hitting a MemoryError. Test with
The patch raises the maximum N to ~8000 on my system (depending on the
load).
OTOH, this probably(?) makes pcolormesh sensitive to later changes in
the input array.
Thoughts?