{{ message }}
Fix polar facecolor - #6001
Merged
Merged
Fix polar facecolor#6001
Conversation
- change name of first kwarg (third arg) of `_AxesBase.__init__` from 'axisbg' -> 'facecolor'. - added 'axisbg' back at the end of the listed kwargs - add handling from axisbg / facecolor conflicts This adds a minor, but nasty, API wart in that there are now two positional arguements to set the background color of the axes and API wise we are locked into one positional arg. However, if any non-None value is passed for `axisbg` a warning will be raised and this is the `__init__` on a private base class so should have reatively little user exposure.
_axisbg -> _facecolor Finishing the change from axisbg -> facecolor
Use `facecolor` not `axisbg`
| @@ -2722,7 +2727,7 @@ def set_axis_bgcolor(self, color): | |||
| warnings.warn( | |||
Member
There was a problem hiding this comment.
Is this warning still needed, given the decorator?
Member
Author
There was a problem hiding this comment.
I think you are correct.
Member
Author
|
Also noticed that we do not even really need that private variable, so fully removed it. |
Member
|
👍 I think this may already be on master, though: 5f1127c |
Member
Author
|
well, drat. |
Member
Author
|
This PR looks like it touches a bit more than #5501 does. This adds face_color as an explicit kwarg that the I need to rip out half of the last commit. |
- the decorator takes care of the warning - fall back got get/set_facecolor instead of private internal state
tacaswell
force-pushed
the
fix_polar_facecolor
branch
from
February 15, 2016 17:17
4f706ae to
9cf717f
Compare
Member
Author
When setting the facecolor stash the value so that future calls to `cla` will restore the facecolor to this value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5996