{{ message }}
Skip svg tex test if tex is not installed - #5770
Merged
Merged
Conversation
Member
Author
Member
|
Does the baseline image need to be updated? Beyond that, I wonder if OrdereredDict isn't enough for the issue if things still come in from TeX in a non-deterministic order. We may need to forcibly sort... |
Member
Author
|
Yes thats true, Not completely sure what happens but this is only an issue on 2.x so presumably ti requires something which is not backported to 2.x |
Borrowed from matplotlib#5677 which is not backported to 2.x
Member
Author
Member
|
The exception changed in the rewrite of the C++ extensions last year, but none of that was in the test suite (since we didn't have TeX+SVG tests until this one). I say we just apply diff --git a/lib/matplotlib/textpath.py b/lib/matplotlib/textpath.py
index c063c3a..b694619 100644
--- a/lib/matplotlib/textpath.py
+++ b/lib/matplotlib/textpath.py
@@ -345,7 +345,7 @@ class TextToPath(object):
1094995778)]:
try:
font.select_charmap(charmap_code)
- except ValueError:
+ except (ValueError, RuntimeError):
pass
else:
breakhere, and not backport all of #5677 -- it turns out there are few issues with it and we may end up reverting it in the long run. |
Member
Author
Member
tacaswell
added a commit
that referenced
this pull request
Dec 31, 2015
Skip svg tex test if tex is not installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This should fix failure on the 2.x branch after the merge of #5766
This should be merged asap to make the 2.x branch pass again