ENH: pass dash_offset through to gc for Line2D by tacaswell · Pull Request #5433 · matplotlib/matplotlib · GitHub
Skip to content

ENH: pass dash_offset through to gc for Line2D - #5433

Merged
mdboom merged 4 commits into
matplotlib:masterfrom
tacaswell:enh_dashoffset
Nov 24, 2015
Merged

ENH: pass dash_offset through to gc for Line2D#5433
mdboom merged 4 commits into
matplotlib:masterfrom
tacaswell:enh_dashoffset

Conversation

@tacaswell

@tacaswell tacaswell commented Nov 7, 2015

Copy link
Copy Markdown
Member

Previously, the user supplied offset to Line2D set_linestyle
was silently discarded. This commit makes the value to be passed
through to the underlying GC on draw, but not all of the backends do
anything with the offset (ex Agg does not).

@tacaswell tacaswell mentioned this pull request Nov 7, 2015
Closed
@tacaswell tacaswell added this to the unassigned milestone Nov 8, 2015
@mdboom

mdboom commented Nov 12, 2015

Copy link
Copy Markdown
Member

@tacaswell

tacaswell commented Nov 12, 2015

Copy link
Copy Markdown
Member Author

We have emailed gh about that issue, we are just too big. The work around
is url hacking as the bug is in generating the drop down menu.

On Thu, Nov 12, 2015, 09:02 Michael Droettboom notifications@github.com
wrote:

See my enh_dashoffset branch. I fixed the Agg backend and the PostScript
backend. All other backends seemed to already work. (Can't make PR against
this because we have too many forks and I can't set yours as the base ?!?)

We should add a test based on your example in #5430
#5430.

—
Reply to this email directly or view it on GitHub
#5433 (comment)
.

@tacaswell tacaswell modified the milestones: proposed next point release (2.1), unassigned Nov 24, 2015
tacaswell and others added 4 commits November 24, 2015 00:23
@tacaswell
ENH: pass dash_offset through to gc for Line2D
50aceb5 
Previously, the user supplied offset to Line2D set_linestyle
was silently discarded.  This commit makes the value to be passed
through to the underlying GC on draw, but not all of the backends do
anything with the offset (ex Agg does not).
@mdboom @tacaswell
Make dash offset work in Agg backend
2df0840
@mdboom @tacaswell
Make dash offset work in PostScript backend
5e75800
@tacaswell
TST: add test of dash offsets
9ee4e99
@tacaswell

tacaswell commented Nov 24, 2015

Copy link
Copy Markdown
Member Author

I think this is ready to go.

mdboom added a commit that referenced this pull request Nov 24, 2015
@mdboom
Merge pull request #5433 from tacaswell/enh_dashoffset
06a08e3 
ENH: pass dash_offset through to gc for Line2D
@mdboom
mdboom merged commit 06a08e3 into matplotlib:master Nov 24, 2015
@mdboom mdboom modified the milestones: next major release (2.0), proposed next point release (2.1) Dec 11, 2015
@mdboom

mdboom commented Dec 11, 2015

Copy link
Copy Markdown
Member

Backported to 2.0.x as d11e344

mdboom added a commit that referenced this pull request Dec 11, 2015
@mdboom
Merge pull request #5433 from tacaswell/enh_dashoffset
d11e344 
ENH: pass dash_offset through to gc for Line2D
@mdboom mdboom mentioned this pull request Dec 11, 2015
Merged
@tacaswell
tacaswell deleted the enh_dashoffset branch December 13, 2015 04:46
@afvincent

afvincent commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

In test_dash_offset(), is it normal to have plt.show() at the end of the test? I just ask this because when I run test_axes in an IPython session, it is the only test that plots something on my screen (and waits for me to close the window to finish the other tests, as plt.ion() is not used).

@tacaswell

tacaswell commented Jun 1, 2016

Copy link
Copy Markdown
Member Author

@afvincent afvincent mentioned this pull request Jun 2, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tacaswell @mdboom @afvincent