{{ message }}
Figure property - #4842
Closed
Mrngilles wants to merge 5 commits into
Closed
Figure property#4842Mrngilles wants to merge 5 commits into
Mrngilles wants to merge 5 commits into
Conversation
Member
There was a problem hiding this comment.
If you are going to do this you should add validation that artists can not be moved between figures.
Member
|
I would not go down this road right now, there is an on-going effort to change all of the Artist attributes into traitlets (#4762) which will supercede this. Sorry for the poor communication and I hope you didn't spend too much time on this! |
Contributor
Author
|
Okay, if the attributes are being changed to traitlets, I guess it's good. I don't know about it too much, so I cannot foresee exactly all the gain the project will get from this switch. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done:
deprecated_get_setfunctionI know the deprecation helper is in a weird place, and I am more than willing to change it, but I had no idea where to put it...
Also, I plan on transforming other attributes (as much as possible) to properties, if you think it is a good idea. If so, do you want a PR per attribute or should I group them?