{{ message }}
FIX: resizing a figure in webagg#4035
Merged
Merged
Conversation
Member
Member
There was a problem hiding this comment.
Style nit: we haven't been using braces if there is only one statement.
Contributor
Author
|
@blink1073 how do I submit a revision to the code? If I remove the brackets and push the new code to my fork on github will the pull request here get automatically synhronized? |
Member
|
Yes, you can keep pushing changes to your |
Contributor
Author
|
Curly braces have been terminated. But an accidental commit was added! |
eyurtsev
force-pushed
the
fix_webagg_resize_02
branch
from
088bedb to
0a245ac
Compare
Contributor
Author
|
Well, just did my first rebase. And forced a push into github repository. There should be only a single commit. :) |
Member
|
Looks good @eyurtsev. You didn't necessarily have to rebase for just one extra commit. |
Member
|
👍 LGTM |
tacaswell
added a commit
that referenced
this pull request
Jan 26, 2015
FIX : resizing a figure in webagg
Member
|
also, improved functionality with a net removal of code! |
tacaswell
added a commit
that referenced
this pull request
Jan 26, 2015
FIX : resizing a figure in webagg
Member
|
back ported as 7468be2 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizing in webagg doesn't work because the figure grabs mouse events (#3338).
This is an iteration over a previous pull request (#3341), including the minimal changes required to fix the problem.
I don't think that the debouncing is necessary anymore, so I removed it. I tested this with both a static plot and animations.
This addresses 90% of the problem.
Resizing issues will reappear if working with multiple figures on the same page.
Refactoring would be necessary probably to introduce some "resizing manager" that will prevent mouse events from being passed to all figures while any figure is being resized.