{{ message }}
Conversation
Member
Contributor
Author
|
I am on it |
Conflicts: lib/matplotlib/tests/test_text.py
Contributor
Author
|
conflict resolved, please note that I still need to fix and add a couple of tests |
Member
There was a problem hiding this comment.
It is easier to add the @cleanup decorator use pyplot to make your figure/axes objects.
Member
There was a problem hiding this comment.
Maybe, I now see why you are doing it this way.
tacaswell
added
the
Release critical
Member
|
I have cherry-picked these over to be based on the 1.4.x branch. I should have a version of this merged in the near future. |
tacaswell
added a commit
that referenced
this pull request
Jan 31, 2015
…w-extent BUG : annotation objects did not report their window extent properl
Member
|
Merged in to v1.4.x as 26c7d65 |
Contributor
Author
|
Thanks @tacaswell. Sorry for the delay. I will make a separate PR for the additional tests. |
Member
|
@itziakos Thanks for your work. Sorry if you feel like I stepped on your toes, I wanted to get this in and this was the fastest path to get there. |
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks
Annotationto provide a get_window_extent method that will return as bounding box the union of the contained text and arrow.Pending: