Repository navigation
Conversation
I did port the conda test as well and now it looks like there must be some architectural difference (or running these tests now when we weren't before) because there are two minor 3d plot image comparison changes. |
a937204 to
8eaedaf
Compare
|
Not sure why the codecov/patch is reporting 0% diff, clicking into it does show the lines are being hit/missed same as before as expected. Looking at the timings, all CI jobs finished in 23 minutes, versus ~33 minutes (or more) on the previous azure/appveyor versions. |
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
There are some similar mentions to AppVeyor/Azure in test_backends_interactive.py as well.
|
Thanks for the review, I addressed all the comments and updated the docs to either remove azure/appveyor references or change to the more generic Windows CI. |
91bcf61 to
606536c
Compare
|
Do we think that this will solve the general flakiness of AppVeyor timing out at the hour mark? Additionally, will this solve the problem where codecov generates false positives because it is missing a build? I'm of the opinion that because it fails so much, the AppVeyor CI is something that we are all subconsciously ignoring. I can review in more detail when I get back tonight; however, I don't know how valuable my review will be on most of this. That said, as long as we are properly testing conda, merging this PR has to be better than having a CI step that we ignore. |
It seems to have fixed itself with the rebases.
Well, this PR removes AppVeyor, so ... yes. |
I… probably should have phrased that differently. I couldn't remember if the timeout issue was inherent to the Windows platform (and thus could show up in GitHub actions as well), inherent to conda, or something to do with AppVeyor itself. |
This branch has not been deployed
3 participants
PR summary
The appveyor and azure jobs frequently have issues and take much longer to run. When doing some quick googling it looks like GitHub Actions uses the same underlying infrastructure but may get more resources per each CI job. This is an attempt to consolidate our CI into one common language so we don't have to know what the configuration formats for multiple CI providers is either.
Since Windows had some bespoke things in it I made this a separate workflow file so we don't overwhelm the existing tests yaml with conditions of
if windows...AI Disclosure
I had AI do the conversion of the configuration files from appveyor/azure into GitHub Actions and read through the output before PRing. I am not fluent in powershell, but it all looks reasonable.