{{ message }}
Improve error message for boxplot_stats function, by printing dimensions. - #32305
Open
carlosgmartin wants to merge 1 commit into
Open
Improve error message for boxplot_stats function, by printing dimensions.#32305carlosgmartin wants to merge 1 commit into
carlosgmartin wants to merge 1 commit into
Conversation
carlosgmartin
force-pushed
the
boxplot_stats_improve_error_message
branch
from
September 5, 2026 18:29
a0fae4d to
dc75afb
Compare
Contributor
|
Note that you need to use "Closes #X" explicitly in the PR in order to link the corresponding issue. See Linking a pull request to an issue using a keyword. |
iccir
approved these changes
Sep 5, 2026
iccir
left a comment
iccir
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I'll let the second reviewer decide if any of the formatting should be changed.
Author
|
@iccir This doesn't close the linked issue. |
jklymak
reviewed
Sep 5, 2026
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
I rephrase this lot directly if we are making a change. "The number of labels ({len(labels)}) must match the number of columns {ncols}." "Compatible with" is vague in this case where there isn't more than one way they are compatible.
carlosgmartin
force-pushed
the
boxplot_stats_improve_error_message
branch
from
September 5, 2026 20:56
dc75afb to
0f2ebb6
Compare
Author
jklymak
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This edits the error message raised by
boxplot_statsfor incompatible dimensions to print those dimensions. This is useful for debugging. Related issue: #32304.AI Disclosure
No AI used.
PR quality check