{{ message }}
Preserve explicitly set figure DPI when pickling - #32233
Open
scorpi023 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #32053
This commit makes set_dpi() update _original_dpi first, then calculates the effective DPI as:
requested DPI × device-pixel ratioThat preserves the user’s DPI choice through pickle round-trips, still behaves correctly on HiDPI displays, and makes savefig(dpi="figure") use the explicitly set DPI.
It also routes SubFigure.set_dpi() through the parent figure’s public setter, so SubFigures follow the same behavior.
Tested normal and HiDPI cases.
AI Disclosure
AI was used for making the change and testing it locally.
PR quality check