{{ message }}
Fixed a bug with drawing an empty Collection - #32228
Merged
Merged
Conversation
ayshih
changed the title
ayshih
marked this pull request as ready for review
August 19, 2026 13:45
Member
Contributor
Author
|
For that concern, I could have |
Member
|
"Artist marked as not visible" and "artist with null data" are different. It is worth it's own |
Contributor
Author
QuLogic
reviewed
Aug 20, 2026
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
QuLogic
approved these changes
Aug 20, 2026
ksunden
approved these changes
Aug 27, 2026
QuLogic
pushed a commit
that referenced
this pull request
Aug 27, 2026
QuLogic
added a commit
that referenced
this pull request
Aug 27, 2026
…228-on-v3.11.x Backport PR #32228 on branch v3.11.x (Fixed a bug with drawing an empty Collection)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The PR fixes a bug (fixes #32219) with drawing an empty scatter plot creating a
PathCollectionwith an emptyoffsetslist. Renderers can interpret this (incorrectly) as wanting a single marker with no offset rather than no markers. This PR simply bails out of thedraw()call whenoffsetsis empty.Fixes a bug revealed in #32219, where specifyingI'm going to create an issue for this because it opened up a can of worms. Edit: Ah, #17790 already exists, so I have created #32232 for discussion.facecolor="none"(oredgecolor="none") went down a different code path than specifying a color. It turns out that specifying"none"would not be understood as a single color – because zero colors is not equal to one color – which would prevent the optimized drawing of a collection when there is just a single path (allowing the use ofdraw_markers()instead ofdraw_path_collection()).AI Disclosure
No AI was used
PR quality check