{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Implement Figure-level overlay architecture with two-pass drawing #32199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vikash-Kumar-23
wants to merge
9
commits into
matplotlib:main
Choose a base branch
from
Vikash-Kumar-23:container-managed-overlays
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d78afb3
Implement Figure-level overlay architecture with two-pass drawing
Vikash-Kumar-23 8efcda9
Fix get_children mypy stub
Vikash-Kumar-23 1f58dd5
Add composite test case for Figure draw layers
Vikash-Kumar-23 6e899bd
Refactor get_children and add_artist layer handling
Vikash-Kumar-23 370d2c8
Remove _children_by_layer initialization from FigureBase
Vikash-Kumar-23 ede6a76
Simplify type-sorting logic in .get_children
Vikash-Kumar-23 1f159cf
Update stale figure callback
Vikash-Kumar-23 d049ac1
Update _stale_figure_callback and move stale layer clearing in _draw_…
Vikash-Kumar-23 a396506
FEAT: Implement Layered Rendering Architecture in QtAgg Backend
Vikash-Kumar-23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+13.1 KB
lib/matplotlib/tests/baseline_images/test_figure/two_pass_base_only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+16.3 KB
lib/matplotlib/tests/baseline_images/test_figure/two_pass_composite.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.6 KB
lib/matplotlib/tests/baseline_images/test_figure/two_pass_overlay_only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

Uh oh!
There was an error while loading. Please reload this page.