{{ message }}
Tweak secondary_{x,y}axis docs. - #31405
Merged
Merged
Conversation
jklymak
approved these changes
Mar 27, 2026
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
Small suggestion though I wonder if this is even an example or the by far predominant use
Member
There was a problem hiding this comment.
Suggested change
| This axis can e.g. display a second x-scale for the data plotted on the Axes. | |
| This axis can, for example, display a second x-scale for the data plotted on the Axes. |
Contributor
Author
There was a problem hiding this comment.
Given the discussion below, I reworded to "is typically used to...". Let me know if you want to stick to "for example".
|
|
||
| For example if we want to have a second scale for the data plotted on | ||
| the yaxis. | ||
| This axis can e.g. display a second y-scale for the data plotted on the Axes. |
Member
There was a problem hiding this comment.
Suggested change
| This axis can e.g. display a second y-scale for the data plotted on the Axes. | |
| This axis can, for example, display a second y-scale for the data plotted on the Axes. |
Member
Use a full sentence with a principal clause. Also, the data is not plotted on the x- or y-axis; it is the scale that is on the x- or y-axis.
timhoffm
approved these changes
Mar 27, 2026
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 28, 2026
QuLogic
pushed a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a full sentence with a principal clause. Also, the data is not plotted on the x- or y-axis; it is the scale that is on the x- or y-axis.
PR summary
AI Disclosure
PR checklist