TST: Restore some tolerances for some arch/platform-specific failures#31343
Conversation
github-project-automation
Bot
moved this to Waiting for other PR
in Font and text overhaul
QuLogic
force-pushed
the
test-tolerance
branch
2 times, most recently
from
9f6c9e9 to
8a451fb
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
QuLogic
force-pushed
the
test-tolerance
branch
2 times, most recently
from
34a33c2 to
4e264da
Compare
|
OK, it does require a bit of internal trickery, but instead of the last commit, we can instead do #31371. |
When outputting files using the "core 14 fonts" (e.g., `rcParams['pdf.use14corefonts'] = True`), text will be measured using our internal AFM files instead of any external files. While we don't have a full API decided for how to pass full `Text` objects through backends, add in a small internal helper to allow the PS/PDF backends to override font height metrics with the AFM files.
|
Rebased on top of #31371 and dropped the AFM test change since that PR's approved. |
|
Test failures are a bit getting out of hand, so that I don't dare to merge. We should fix setuptools scm, likely temporarily by pinning <10.0, see #31387. |
QuLogic
force-pushed
the
test-tolerance
branch
2 times, most recently
from
6c45be8 to
0d95526
Compare
|
OK, I've pinned setuptools-scm for this branch and I think I've got all the places. Unfortunately, since this branch hasn't been merged with |
|
OK, looks like I didn't increase one tolerance enough, and |
So before the AFM change, the minimum ascent was 15.1953125, and after it's 15.195312499999996 which causes only the A in the legend to shift slightly. I don't think that's too important, so I've just updated the final figure in the other branch and restarted the CI here. |
|
Trying to re-trigger Azure, which seems to have not run lately. |
github-project-automation
Bot
moved this from Ready for Review
to Done
in Font and text overhaul
github-project-automation
Bot
moved this from Done
to In Progress
in Font and text overhaul
The tolerances on these were increased in various PRs, with notes to reduce/remove them, so they were removed in matplotlib#30184, but should have been reverted to a smaller value: - `test_floating_axes.py::test_curvelinear4[png]` fails on macOS - `test_grid_helper_curvelinear.py::test_axis_direction[png]` fails on ARM and macOS - `test_grid_helper_curvelinear.py::test_polar_box[png]` fails on Windows, ARM, and macOS These fail on macOS; there's tolerances on them already, they fail by just a small amount, so increase them: - `test_bbox_tight.py::test_bbox_inches_tight_suptile_legend[png]` - `test_patheffects.py::test_collection[png]` - `test_axes3d.py::test_scale3d_artists_log[png]` This fails only on AppVeyor (Windows), but not Azure. There is a tolerance there already, so just add it to the list: - `test_mathtext.py::test_mathtext_rendering`
This is currently causing warnings at runtime in the editable install, which breaks almost all tests.
github-project-automation
Bot
moved this from Ready for Review
to Done
in Font and text overhaul
4 participants
PR summary
The tolerances on these were increased in various PRs, with notes to reduce/remove them, so they were removed in #30184, but should have been reverted to a smaller value:
test_floating_axes.py::test_curvelinear4[png]fails on macOStest_grid_helper_curvelinear.py::test_axis_direction[png]fails on ARM and macOStest_grid_helper_curvelinear.py::test_polar_box[png]fails on Windows, ARM, and macOSThese fail on macOS; there's tolerances on them already, they fail by just a small amount, so increase them:
test_bbox_tight.py::test_bbox_inches_tight_suptile_legend[png]test_patheffects.py::test_collection[png]test_axes3d.py::test_scale3d_artists_log[png]This fails only on AppVeyor (Windows), but not Azure. There is a tolerance there already, so just add it to the list:
test_mathtext.py::test_mathtext_renderingAI Disclosure
None
PR checklist