{{ message }}
MNT: Change default name of ListedColormaps - #30532
Merged
Merged
Conversation
from "from_list" to "unnamed", which makes more sense logically. While technically a breaking change, I anticipate that nobody is relying on that default value.
timhoffm
force-pushed
the
listedcolormap-name
branch
from
September 8, 2025 22:02
2a8c8e0 to
2dd8175
Compare
QuLogic
reviewed
Sep 9, 2025
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
QuLogic
approved these changes
Sep 9, 2025
Member
Member
|
I have some reservations, but on balance I am 👍🏻 on this change. |
Member
Author
|
Trying to confirm my "nobody would rely on this rather brittle information" assumtion, I found one actual usage: and two likely out-of date usages (repo not updated for two 2 years) https://github.com/jasperroebroek/geomappy/blob/4fbf41f52befd0155a071d6558f2d0549e0c7454/tests/test_classified_params.py#L10 What does this mean? Should we a. revert and leave this be or |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from "from_list" to "unnamed", which makes more sense logically.
While technically a breaking change, I anticipate that nobody is relying
on that default value.
Part of #29141.