{{ message }}
Adjust logic in RcParams to allow for inheritance - #30245
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
Thanks! Is there anything I can read up on potential changes to RcParams you are considering? |
Member
no concise summary as there’s no concrete plan yet. You can have a look at the above linked items to get some ideas.
So all you need is additional parameters for your library? That’s something we consider to natively support one way or the other in the future. |
Contributor
Author
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We over at UltraPlot ran into an issue where I wanted to derrive our RcClass directly from matplotlib's RcParams. However, in the source I noticed there are two places where the class hardcodes the class itself. This PR addresses this issue by making that initialization tied to the class type, opening up the potential for direct inheritance without needing to override these methods.