FUTURE BUG: reconsider how we deep-copy path objects #29157 by saikarna913 · Pull Request #29161 · matplotlib/matplotlib · GitHub
Skip to content

FUTURE BUG: reconsider how we deep-copy path objects #29157 - #29161

Closed
saikarna913 wants to merge 2 commits into
matplotlib:mainfrom
saikarna913:Feature2
Closed

saikarna913 wants to merge 2 commits into
matplotlib:mainfrom
saikarna913:Feature2

Conversation

@saikarna913

Copy link
Copy Markdown
Contributor

PR summary

  • it is necessary to solve the infinite recursion in __deep_copy__ function in path.py
  • it is creating the deep copy without infinite recursion
  • adding the memo dictionary with id as the self and value as the new instance created , makes the deep copy to stop the infinite recursion when same class is called since in MRO, the object will be the path class since there are no super classes for the path class which searches for __deep_copy__

PR checklist

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell

Copy link
Copy Markdown
Member

@rcomer

rcomer commented Nov 24, 2024

Copy link
Copy Markdown
Member

@saikarna913 saikarna913 closed this by deleting the head repository Dec 8, 2024
@melissawm melissawm moved this from Waiting for author to Done in First Time Contributors Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

FUTURE BUG: reconsider how we deep-copy path objects

4 participants