{{ message }}
FIX: contourf hatches use multiple edgecolors - #28993
Merged
Merged
Conversation
timhoffm
approved these changes
Oct 19, 2024
Member
There was a problem hiding this comment.
Suggested change
| all_edgecolors = self.get_edgecolors() | |
| edgecolors = self.get_edgecolors() |
Slight preference for leaving out the all_ prefix. It does not convey information.
rcomer
force-pushed
the
contour-hatch-colors
branch
from
October 19, 2024 19:19
cde45c4 to
08e6552
Compare
Member
|
If possible, let's also backport to 3.9 to have a version that supports both the old and new syntax and thus have a smoother transition. |
kiruthikpurpose
approved these changes
Oct 21, 2024
ksunden
approved these changes
Oct 21, 2024
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 22, 2024
1 task
timhoffm
added a commit
that referenced
this pull request
Oct 22, 2024
…3.9.x Backport PR #28993 on branch v3.9.x (FIX: contourf hatches use multiple edgecolors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #28990. I think it would be good to get this minor fix in for v3.10 since the example from the issue will otherwise not be possible to plot (and it is possible at v3.9 using the deprecated
collectionsattribute).I note that passing edgecolors to
contourfresults in a warning that the parameter is ignored. This seems inconsistent with being able to set them afterContourSetinstantiation. However, I propose to ignore the inconsistency for now and think about it later when a release is not imminent.PR checklist