MNT: Warn if fixed aspect overwrites explicitly set data limits - #28683
Conversation
There was a problem hiding this comment.
Note: I've intentionally written may because in the current implementation one can have scenarios where the limits are respected. For example
fig, ax = plt.subplots()
ax.set_aspect('equal', 'datalim')
ax.plot([0, 1], [0, 2])
ax.set_ylim(-5, 5)
Just looking at the data, the y-range is larger, so to get all data shown on equal aspect, x has to be increased. Thus, new xlims are calculated, but taking the ylim (not the ydata) into account. Whether this behavior of sometimes taking limits into account and sometimes not is desireable, is a separate question that I don't want to discuss. The doc now only states that it may (or may not) happen. Note however, that the added runtime warning is precise: It will be emitted exactly if we change previously fixed limits.
|
I do not think users will see this by default (or I may be confused about logging)? |
|
I also am not sure that we want to backport this. It is a minor change to long standing behavior. |
ksunden
left a comment
ksunden
left a comment
There was a problem hiding this comment.
Approved during discussion in community call
5 participants
Closes #28673.