DOC: improve tagging guidelines page by story645 · Pull Request #28527 · matplotlib/matplotlib · GitHub
Skip to content

DOC: improve tagging guidelines page - #28527

Merged
story645 merged 3 commits into
matplotlib:mainfrom
story645:tag-guide
Jul 11, 2024
Merged

story645 merged 3 commits into
matplotlib:mainfrom
story645:tag-guide

Conversation

@story645

@story645 story645 commented Jul 9, 2024

Copy link
Copy Markdown
Member

Based on discussions w/ @esibing after #27235 and so it's improved for scipy sprints, cleaned up the tagging page so:

  • list of categories pulls from glossary section headings so will remain in sync
  • added a code example of how to add tags
  • move content guidelines to writing guide -> I don't want/expect it to stay there, but think it's distracting here.

Also, thanks to @melissawm and melissawm/sphinx-tags#102

  • enable multiline

PR summary

PR checklist

@story645 story645 added Documentation: devdocs files in doc/devel Documentation: tags tagging examples + proposing new tags labels Jul 9, 2024
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/_static/mpl.css Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/_static/mpl.css Outdated
Comment thread doc/devel/tag_guidelines.rst Outdated
@story645
story645 force-pushed the tag-guide branch 2 times, most recently from 37587bf to 502fb6b Compare July 9, 2024 21:13
@story645

story645 commented Jul 9, 2024

Copy link
Copy Markdown
Member Author

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take or leave my comments. You can self-merge after that (and fixing the sphinx build).

Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst

All :ref:`examples-index` should aim to follow these guidelines:

:Title: Describe content in a short sentence (approx. 1-6 words). Do not use *demo* as

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does sentence imply a full sentence including verb? Possible alternatives: expression, phrase ... (not a native speaker so cannot really judge)

Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/devel/document.rst Outdated
Comment thread doc/_static/mpl.css Outdated
Comment thread doc/_static/mpl.css Outdated
story645 and others added 3 commits July 11, 2024 05:12
add coding example
move content guidelines to writing guide
enable multiline

Co-authored-by: Eva Sibinga <46283995+esibinga@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@story645
story645 merged commit 48c8f07 into matplotlib:main Jul 11, 2024
@story645

story645 commented Jul 11, 2024

Copy link
Copy Markdown
Member Author

@QuLogic QuLogic added this to the v3.10.0 milestone Jul 12, 2024
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Jul 12, 2024
Following recommendatinos from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Jul 27, 2024
Following recommendatinos from matplotlib#28527, this improves example titles.
Take this as an incremental improvement. I've changed what I saw at a
glance when going through the examples once. Certainly, one could do
further improvements, but that can be done in follow-ups.

Co-authored-by: hannah <story645@gmail.com>
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Aug 1, 2024
Follow up to matplotlib#28544. As there:

Following recommendations from matplotlib#28527, this improves example titles.
Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Aug 1, 2024
Follow up to matplotlib#28544. As there:

Following recommendations from matplotlib#28527, this improves example titles.
Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Aug 1, 2024
Follow up to matplotlib#28544. As there:

Following recommendations from matplotlib#28527, this improves example titles.
Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Aug 1, 2024
Follow up to matplotlib#28544. As there:

Following recommendations from matplotlib#28527, this improves example titles.
Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Aug 2, 2024
Follow up to matplotlib#28544. As there:

Following recommendations from matplotlib#28527, this improves example titles.
Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Aug 2, 2024
Follow up to matplotlib#28544. As there:

Following recommendations from matplotlib#28527, this improves example titles.
Take this as an incremental improvement. I've changed what I saw  t a
glance when going through the examples once. Certainly, one could do
further improvements, but that can be done in follow-ups.

Co-authored-by: hannah <story645@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: build building the docs Documentation: devdocs files in doc/devel Documentation: tags tagging examples + proposing new tags

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants